eyalzit commented on a change in pull request #24382: [SPARK-27330][SS] support
task abort in foreach writer
URL: https://github.com/apache/spark/pull/24382#discussion_r276108333
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/sources/ForeachWriterSuite.scala
##########
@@ -303,6 +347,13 @@ class TestForeachWriter extends ForeachWriter[Int] {
override def close(errorOrNull: Throwable): Unit = {
events += ForeachWriterSuite.Close(error = Option(errorOrNull))
+ if (errorOrNull == null) {
Review comment:
since now abort is invoked after the close, i would like make sure that the
events are not added twice
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
