eyalzit commented on a change in pull request #24382: [SPARK-27330][SS] support
task abort in foreach writer
URL: https://github.com/apache/spark/pull/24382#discussion_r276125984
##########
File path: docs/structured-streaming-programming-guide.md
##########
@@ -2145,6 +2145,10 @@ streamingDatasetOfString.writeStream.foreach(
def close(errorOrNull: Throwable): Unit = {
// Close the connection
}
+
+ def abort(): Unit = {
+ // Close the connection, this method is optional
Review comment:
that was my original thought but i didn't want to call close twice each time
with a different exception
will it make sense to add a flag to the ForeachDataWriter which will
indicate if the writer has been closed (close has been called) and invoke the
close on abort only if closed hasn't need called?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
