mccheah commented on a change in pull request #24246: [SPARK-24252][SQL] Add
TableCatalog API
URL: https://github.com/apache/spark/pull/24246#discussion_r276874653
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalog/v2/expressions/expressions.scala
##########
@@ -183,17 +149,10 @@ private[sql] final case class LiteralValue[T](value: T,
dataType: DataType) exte
}
private[sql] final case class FieldReference(parts: Seq[String]) extends
NamedReference {
+ import org.apache.spark.sql.catalog.v2.CatalogV2Implicits._
Review comment:
My understanding of Scala implicits is that the implicit conversions or
methods are exactly that - implicit - so they can be called without
specifically invoking the method names. So a common philosophy around implicits
is to only import them if such conversions are definitely required. Otherwise
we can create side effects of calling the implicit methods when we don't mean
to.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
