mccheah commented on a change in pull request #24246: [SPARK-24252][SQL] Add
TableCatalog API
URL: https://github.com/apache/spark/pull/24246#discussion_r277048232
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalog/v2/expressions/expressions.scala
##########
@@ -183,17 +149,10 @@ private[sql] final case class LiteralValue[T](value: T,
dataType: DataType) exte
}
private[sql] final case class FieldReference(parts: Seq[String]) extends
NamedReference {
+ import org.apache.spark.sql.catalog.v2.CatalogV2Implicits._
Review comment:
I still think that here we should only be importing the specific method
that's used - maybe move `quoted` to a helper class. If we really need the
implicits functionality we can import it later on. Can we do that?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
