vanzin commented on a change in pull request #24305: [SPARK-27294][SS] Add
multi-cluster Kafka delegation token
URL: https://github.com/apache/spark/pull/24305#discussion_r279463908
##########
File path:
external/kafka-0-10-token-provider/src/main/scala/org/apache/spark/kafka010/KafkaTokenUtil.scala
##########
@@ -222,14 +230,25 @@ private[spark] object KafkaTokenUtil extends Logging {
}
}
- def isTokenAvailable(): Boolean = {
- UserGroupInformation.getCurrentUser().getCredentials.getToken(
- KafkaTokenUtil.TOKEN_SERVICE) != null
+ def findMatchingToken(sparkConf: SparkConf,
+ bootStrapServers: String): Option[KafkaTokenClusterConf] = {
+ val tokens =
UserGroupInformation.getCurrentUser().getCredentials.getAllTokens.asScala
+ val clusterConfigs = tokens
+ .filter(_.getService().toString().startsWith(TOKEN_SERVICE_PREFIX))
+ .map { token =>
+ KafkaTokenSparkConf.getClusterConfig(sparkConf,
getClusterIdentifier(token.getService()))
+ }
+ .filter { clusterConfig =>
+
Pattern.compile(clusterConfig.targetServersRegex).matcher(bootStrapServers).matches()
Review comment:
That's a very simplistic case. In that case the `.*` is matching
"host1.company.com:9092,host2.", and the rest is matching the end of the config.
I think it's much better, easier to understand, and less prone to errors to
have the regex match individual addresses instead of the whole string. It's
just a matter of calling `Utils.stringToSeq` before applying the regex.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
