vanzin commented on a change in pull request #24305: [SPARK-27294][SS] Add
multi-cluster Kafka delegation token
URL: https://github.com/apache/spark/pull/24305#discussion_r279860716
##########
File path:
external/kafka-0-10-token-provider/src/test/scala/org/apache/spark/kafka010/KafkaDelegationTokenTest.scala
##########
@@ -70,15 +71,19 @@ trait KafkaDelegationTokenTest extends BeforeAndAfterEach {
Configuration.setConfiguration(new KafkaJaasConfiguration)
}
- protected def addTokenToUGI(): Unit = {
+ protected def addTokenToUGI(identifier: String, tokenService: Option[String]
= None): Unit = {
Review comment:
This signature is throwing me off when trying to understand the tests.
It seems that if you set the token service, then `identifier` is completely
unused. Wouldn't it be simpler to just have the token service as an argument?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
