dongjoon-hyun commented on a change in pull request #24469: [SPARK-27576][SQL] table capability to skip the output column resolution URL: https://github.com/apache/spark/pull/24469#discussion_r279609273
########## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2Relation.scala ########## @@ -44,6 +44,8 @@ case class DataSourceV2Relation( override def name: String = table.name() + override def requireSchemaMatch: Boolean = !table.supports(TableCapability.ACCEPT_ANY_SCHEMA) Review comment: This also can be switched in a more natural(positive) way. ```scala - override def requireSchemaMatch: Boolean = !table.supports(TableCapability.ACCEPT_ANY_SCHEMA) + override def ignoreSchemaMatch: Boolean = table.supports(TableCapability.ACCEPT_ANY_SCHEMA) ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
