viirya commented on a change in pull request #24494: SPARK-27586: Improve
binary comparison: replace Scala's for-comprehen…
URL: https://github.com/apache/spark/pull/24494#discussion_r279638699
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/util/TypeUtilsSuite.scala
##########
@@ -43,4 +43,28 @@ class TypeUtilsSuite extends SparkFunSuite {
typeCheckPass(ArrayType(StringType, containsNull = true) ::
ArrayType(StringType, containsNull = false) :: Nil)
}
+
+ test("compareBinary") {
+ def oldVersion(x: Array[Byte], y: Array[Byte]): Int = {
Review comment:
This test case looks not useful to me. It's also confusing. We don't know
what old version means without the context of this PR.
Since this is a refactoring work, if we have enough tests for
`compareBinary`, passing these tests sounds good enough. If we don't have, it
is good time to add some.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
