viirya commented on a change in pull request #24494: SPARK-27586: Improve
binary comparison: replace Scala's for-comprehen…
URL: https://github.com/apache/spark/pull/24494#discussion_r279639630
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/TypeUtils.scala
##########
@@ -73,11 +73,12 @@ object TypeUtils {
}
def compareBinary(x: Array[Byte], y: Array[Byte]): Int = {
- for (i <- 0 until x.length; if i < y.length) {
- val v1 = x(i) & 0xff
- val v2 = y(i) & 0xff
- val res = v1 - v2
+ val limit = math.min(x.length, y.length)
Review comment:
Which is better? `math.min` or simply `if else`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
