rdblue commented on a change in pull request #24469: [SPARK-27576][SQL] table
capability to skip the output column resolution
URL: https://github.com/apache/spark/pull/24469#discussion_r280126040
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/NamedRelation.scala
##########
@@ -21,4 +21,7 @@ import
org.apache.spark.sql.catalyst.plans.logical.LogicalPlan
trait NamedRelation extends LogicalPlan {
def name: String
+
+ // When true, the schema of input data must match the schema of this
relation, during write.
+ def requireSchemaMatch: Boolean = true
Review comment:
Separate from the discussion about the method name, I don't think it makes
sense for this to be in `NamedRelation`.
`NamedRelation` exists to help create better error messages from the generic
rules that apply across any relation. This addition doesn't fit with that
purpose. I think the reason why this was added to `NamedRelation` is because
the v2 relation class is not available to catalyst, but this rule is in
catalyst. If that's the case, then this depends on moving v2 into catalyst and
I think it makes sense to do that first.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
