rdblue commented on a change in pull request #24469: [SPARK-27576][SQL] table
capability to skip the output column resolution
URL: https://github.com/apache/spark/pull/24469#discussion_r280127334
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/DataSourceV2AnalysisSuite.scala
##########
@@ -446,6 +452,22 @@ abstract class DataSourceV2AnalysisSuite extends
AnalysisTest {
"Cannot safely cast", "'x'", "DoubleType to FloatType"))
}
+ test("bypass output column resolution") {
+ val table = TestRelationAcceptAnySchema(StructType(Seq(
+ StructField("a", FloatType, nullable = false),
+ StructField("b", DoubleType))).toAttributes)
+
+ val query = TestRelation(StructType(Seq(
+ StructField("s", StringType))).toAttributes)
+
+ val plan1 = byName(table, query)
Review comment:
The rest of the test cases in this class test either by name or by position,
and I would like for this to keep using that convention. When test cases fail,
it is easier to see what happened because the case is specific to one path. It
also avoids using names that are not specific, like `plan1` and `plan2`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
