srowen commented on a change in pull request #24531: [SPARK-27636][MLLIB]Remove
cached RDD blocks after PIC execution
URL: https://github.com/apache/spark/pull/24531#discussion_r281042277
##########
File path:
mllib/src/main/scala/org/apache/spark/mllib/clustering/PowerIterationClustering.scala
##########
@@ -226,11 +226,14 @@ class PowerIterationClustering private[clustering] (
*/
private def pic(w: Graph[Double, Double]): PowerIterationClusteringModel = {
val v = powerIter(w, maxIterations)
- val assignments = kMeans(v, k).mapPartitions({ iter =>
+ val kMeansModel = kMeans(v, k)
+ val assignments = kMeansModel.mapPartitions({ iter =>
Review comment:
I'm actually not sure why it calls `.mapPartitions` here. There's nothing
partition-wise about it. I think this could also just be:
```
val assignments = kMeansModel.map { case (id, cluster) => Assignment(id,
cluster) }
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
