srowen commented on a change in pull request #24531: [SPARK-27636][MLLIB]Remove
cached RDD blocks after PIC execution
URL: https://github.com/apache/spark/pull/24531#discussion_r281042299
##########
File path:
mllib/src/main/scala/org/apache/spark/mllib/clustering/PowerIterationClustering.scala
##########
@@ -296,12 +299,15 @@ object PowerIterationClustering extends Logging {
},
mergeMsg = _ + _,
TripletFields.EdgeOnly)
- Graph(vD, gA.edges)
- .mapTriplets(
- e => e.attr / math.max(e.srcAttr, MLUtils.EPSILON),
- new TripletFields(/* useSrc */ true,
- /* useDst */ false,
- /* useEdge */ true))
+ val graph = Graph(vD, gA.edges).mapTriplets(
+ e => e.attr / math.max(e.srcAttr, MLUtils.EPSILON),
+ new TripletFields(/* useSrc */ true,
+ /* useDst */ false,
+ /* useEdge */ true))
+ materialize(graph)
+ gA.unpersist(true)
Review comment:
No need to set blocking = true. Just don't specify.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
