squito commented on a change in pull request #24499: [SPARK-25888][Core] Serve local disk persisted blocks by the external service after releasing executor by dynamic allocation URL: https://github.com/apache/spark/pull/24499#discussion_r281803771
########## File path: core/src/main/scala/org/apache/spark/storage/BlockManagerMaster.scala ########## @@ -223,11 +223,12 @@ class BlockManagerMaster( } /** - * Find out if the executor has cached blocks. This method does not consider broadcast blocks, - * since they are not reported the master. + * Find out if the executor has cached blocks which are not available via the external shuffle + * service. + * This method does not consider broadcast blocks, since they are not reported the master. Review comment: ... not reported to the master. (missing "to", I know that was a typo from before) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
