squito commented on a change in pull request #24499: [SPARK-25888][Core] Serve
local disk persisted blocks by the external service after releasing executor by
dynamic allocation
URL: https://github.com/apache/spark/pull/24499#discussion_r282996910
##########
File path:
common/network-common/src/test/java/org/apache/spark/network/server/OneForOneStreamManagerSuite.java
##########
@@ -30,22 +31,47 @@
public class OneForOneStreamManagerSuite {
@Test
- public void managedBuffersAreFeedWhenConnectionIsClosed() throws Exception {
+ public void testMissingChunk() {
OneForOneStreamManager manager = new OneForOneStreamManager();
List<ManagedBuffer> buffers = new ArrayList<>();
TestManagedBuffer buffer1 = Mockito.spy(new TestManagedBuffer(10));
TestManagedBuffer buffer2 = Mockito.spy(new TestManagedBuffer(20));
+ TestManagedBuffer buffer3 = Mockito.spy(new TestManagedBuffer(20));
+
buffers.add(buffer1);
+ buffers.add(null);
buffers.add(buffer2);
+ buffers.add(null);
+ buffers.add(buffer3);
Channel dummyChannel = Mockito.mock(Channel.class,
Mockito.RETURNS_SMART_NULLS);
- manager.registerStream("appId", buffers.iterator(), dummyChannel);
- assert manager.numStreamStates() == 1;
+ long streamId = manager.registerStream("appId", buffers.iterator(),
dummyChannel);
+ Assert.assertEquals(1, manager.numStreamStates());
+ Assert.assertNotNull(manager.getChunk(streamId, 0));
+ Assert.assertNull(manager.getChunk(streamId, 1));
+ Assert.assertNotNull(manager.getChunk(streamId, 2));
+ manager.connectionTerminated(dummyChannel);
+ Mockito.verify(buffer1, Mockito.never()).release();
+ Mockito.verify(buffer2, Mockito.never()).release();
Review comment:
why don't these get released?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
