turboFei commented on a change in pull request #24533: [SPARK-27637] For
nettyBlockTransferService, when exception occurred when fetching data, check
whether relative executor is alive before retry
URL: https://github.com/apache/spark/pull/24533#discussion_r282717624
##########
File path:
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/RetryingBlockFetcher.java
##########
@@ -143,11 +167,22 @@ private void fetchAllOutstanding() {
logger.error(String.format("Exception while beginning fetch of %s
outstanding blocks %s",
blockIdsToFetch.length, numRetries > 0 ? "(after " + numRetries + "
retries)" : ""), e);
- if (shouldRetry(e)) {
Review comment:
> shouldn't we just change this line to `if (shouldRetry(e) &&
!executorAliveChecker.check())`?
Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
