turboFei commented on a change in pull request #24533: [SPARK-27637] For
nettyBlockTransferService, when exception occurred when fetching data, check
whether relative executor is alive before retry
URL: https://github.com/apache/spark/pull/24533#discussion_r282722504
##########
File path:
core/src/main/scala/org/apache/spark/storage/BlockManagerMasterEndpoint.scala
##########
@@ -325,6 +328,10 @@ class BlockManagerMasterEndpoint(
}.toMap
}
+ private def isExecutorAlive(executorId: String): Boolean = {
+ blockManagerIdByExecutor.contains(executorId)
Review comment:
> This is just a one-line method, can we inline it?
Done.
@cloud-fan Thanks for your valuable advices, I think there are no other
problems.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
