Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/3869#discussion_r22424322
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/linalg/VectorsSuite.scala ---
@@ -175,6 +175,42 @@ class VectorsSuite extends FunSuite {
assert(v.size === x.rows)
}
+ test("sqdist") {
+ val a = (30 to 0 by -1).map(math.pow(2.0, _)).toArray
+ val n = a.length
+ val v1 = Vectors.dense(a)
+ for (m <- 0 until n) {
+ val indices = (0 to m).toArray
+ val values = indices.map(i => a(i))
+ val v2 = Vectors.sparse(n, indices, values)
+ val v3 = Vectors.sparse(n, indices, indices.map(i => a(i) + 0.5))
+
+ // DenseVector vs. SparseVector
+ val squaredDist = breezeSquaredDistance(v1.toBreeze, v2.toBreeze)
+ val fastSquaredDist1 = Vectors.sqdist(v1, v2)
+ assert(fastSquaredDist1 == squaredDist)
+
+ // DenseVector vs. DenseVector
+ val fastSquaredDist2 = Vectors.sqdist(v1, Vectors.dense(v2.toArray))
+ assert(fastSquaredDist2 === squaredDist)
+
+ // SparseVector vs. SparseVector
+ val squaredDist2 = breezeSquaredDistance(v2.toBreeze, v3.toBreeze)
+ val fastSquaredDist3 = Vectors.sqdist(v2, v3)
+ assert(fastSquaredDist3 === squaredDist2)
+
+ // SparseVector vs. SparseVector: with values at different indices
+ if (m > 10) {
+ val v4 = Vectors.sparse(n, indices.slice(0, m - 10),
+ indices.map(i => a(i) + 0.5).slice(0, m - 10))
+ val squaredDist = breezeSquaredDistance(v2.toBreeze, v4.toBreeze)
+ val fastSquaredDist =
--- End diff --
Can fit on 1 line instead of 2
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
