Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/3869#issuecomment-68566521
@viirya Looks OK to me, except for the tiny comments. Thanks!
At some point, it might be nice to replace these tests with ones using
random dense & sparse vectors (with random sparsity patterns). If you are
interested in doing that, I can send you a method for generating random sparse
vectors which I used for the timing tests.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
