szhem commented on a change in pull request #24556: [SPARK-27641][CORE] Fix
MetricsSystem to remove unregistered source correctly
URL: https://github.com/apache/spark/pull/24556#discussion_r283147760
##########
File path: core/src/main/scala/org/apache/spark/metrics/MetricsSystem.scala
##########
@@ -166,9 +172,12 @@ private[spark] class MetricsSystem private (
}
def removeSource(source: Source) {
- sources -= source
- val regName = buildRegistryName(source)
- registry.removeMatching((name: String, _: Metric) =>
name.startsWith(regName))
+ val index = sources.indexOf(source)
+ if (index != -1) {
+ sources.remove(index)
+ val regNames = getRegisteredNames(source)
+ registry.removeMatching((name: String, _: Metric) =>
regNames.contains(name))
Review comment:
Is it really necessary to iterate over all the metrics in the registry to
remove the necessary metrics?
Isn't it more efficient just to remove the metrics from the registry by
their names using `MetricRegistry.remove(String)`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
