szhem commented on a change in pull request #24556: [SPARK-27641][CORE] Fix
MetricsSystem to remove unregistered source correctly
URL: https://github.com/apache/spark/pull/24556#discussion_r283147798
##########
File path:
core/src/main/scala/org/apache/spark/metrics/source/AccumulatorSource.scala
##########
@@ -81,9 +82,10 @@ object LongAccumulatorSource {
*/
@Experimental
object DoubleAccumulatorSource {
- def register(sc: SparkContext, accumulators: Map[String,
DoubleAccumulator]): Unit = {
+ def register(sc: SparkContext, accumulators: Map[String,
DoubleAccumulator]): Source = {
val source = new DoubleAccumulatorSource
source.register(accumulators)
sc.env.metricsSystem.registerSource(source)
+ source
Review comment:
What is the reason of changing this public API and exposing the package
private `Source`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
