Github user tdas commented on the pull request:
https://github.com/apache/spark/pull/3832#issuecomment-68616268
Yes, this is hardly a valid used case of `transform`. I took a look at the
unit test, and I think I know why it works. But this unit test is very very
obfuscated, and hard to understand why it works. Does it even fail reliably
without the fix? Because if it does not fail reliably without the fix then
there isnt much point of having it. If it fails reliably without the fix, and
does not fail reliably with the fix, then I am okay with unit test as long as
there is sufficient comments explaining how this unit test works. Maybe we can
open another JIRA mentioning the exceptions that do not get propagated which
makes this unit test so complicated. And refer to the JIRA in the comments
around the unit test. Other than that I think I am okay. For this subtle an
issue (validity checks), its better to have some unit test than have none at
all.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
