Github user tdas commented on a diff in the pull request:

    https://github.com/apache/spark/pull/3832#discussion_r22447201
  
    --- Diff: 
streaming/src/test/scala/org/apache/spark/streaming/CheckpointSuite.scala ---
    @@ -255,6 +255,45 @@ class CheckpointSuite extends TestSuiteBase {
         }
       }
     
    +  test("recovery with saveAsHadoopFile inside transform operation") {
    +    // Regression test for SPARK-4835.
    +    //
    +    // In that issue, the problem was that `saveAsHadoopFile(s)` would 
fail when the last batch
    +    // was restarted from a checkpoint since the output directory would 
already exist.  However,
    +    // the other saveAsHadoopFile* tests couldn't catch this because they 
only tested whether the
    +    // output matched correctly and not whether the post-restart batch had 
successfully finished
    +    // without throwing any errors.  The following test reproduces the 
same bug with a test that
    --- End diff --
    
    nit: extra space before `The following`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to