dongjoon-hyun commented on a change in pull request #24598: [SPARK-27699][SQL]
Partially push down disjunctive predicated in Parquet/ORC
URL: https://github.com/apache/spark/pull/24598#discussion_r284369791
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilters.scala
##########
@@ -527,11 +527,22 @@ private[parquet] class ParquetFilters(
}
case sources.Or(lhs, rhs) =>
+ // The Or predicate is convertible when both of its children can be
pushed down.
+ // That is to say, if one/both of the children can be partially pushed
down, the Or
+ // predicate can be partially pushed down as well.
+ //
+ // Here is an example used to explain the reason.
+ // Let's say we have
+ // (a1 AND a2) OR (b1 AND b2),
+ // a1 and b1 is convertible, while a2 and b2 is not.
+ // The predicate can be converted as
+ // (a1 OR b1) AND (a1 OR b2) AND (a2 OR b1) AND (a2 OR b2)
Review comment:
@gengliangwang . You can use `explain` with `Console.withOut`. What we need
is to check `PushedFilters: ` in the plan.
> How can we verify the predicate is pushed down? Match the OrcScan and
check the pushedFilters? Only Orc V2 can be checked in this way currently.
@cloud-fan and @gengliangwang . Yes. Of course, I already agreed that the
rule is correct. I want to have a test case in a complete end-to-end query form
which shows the new benefit clearly. Could you please add a real use case you
met?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
