dongjoon-hyun commented on a change in pull request #24598: [SPARK-27699][SQL]
Partially push down disjunctive predicated in Parquet/ORC
URL: https://github.com/apache/spark/pull/24598#discussion_r284780244
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2Strategy.scala
##########
@@ -46,25 +46,30 @@ object DataSourceV2Strategy extends Strategy with
PredicateHelper {
case r: SupportsPushDownFilters =>
// A map from translated data source filters to original catalyst
filter expressions.
val translatedFilterToExpr = mutable.HashMap.empty[sources.Filter,
Expression]
+ val translatedFilters = mutable.ArrayBuffer.empty[sources.Filter]
// Catalyst filter expression that can't be translated to data source
filters.
val untranslatableExprs = mutable.ArrayBuffer.empty[Expression]
for (filterExpr <- filters) {
- val translated = DataSourceStrategy.translateFilter(filterExpr)
- if (translated.isDefined) {
- translatedFilterToExpr(translated.get) = filterExpr
- } else {
+ val translated =
Review comment:
Yep. Actually, when I tested your PR before, I also noticed that. The new
`Or` doesn't work in the end-to-end case. That's the reason to ask this. I'll
test more.
Thank you for making this PR working, @gengliangwang !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
