vanzin commented on a change in pull request #24616: [SPARK-27726] [Core] Fix 
performance of ElementTrackingStore deletes when using InMemoryStore under high 
loads
URL: https://github.com/apache/spark/pull/24616#discussion_r285313350
 
 

 ##########
 File path: 
common/kvstore/src/main/java/org/apache/spark/util/kvstore/KVStore.java
 ##########
 @@ -126,4 +127,9 @@
    */
   long count(Class<?> type, String index, Object indexedValue) throws 
Exception;
 
+  /**
+   * A cheaper way to remove multiple items from the KVStore
+   */
+  <T> boolean removeAllByIndexValues(Class<T> klass, String index, 
Collection<?> indexValues)
+          throws Exception;
 
 Review comment:
   nit: indented too much (2 or 4 spaces is fine here)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to