vanzin commented on a change in pull request #24616: [SPARK-27726] [Core] Fix
performance of ElementTrackingStore deletes when using InMemoryStore under high
loads
URL: https://github.com/apache/spark/pull/24616#discussion_r285753585
##########
File path:
common/kvstore/src/test/java/org/apache/spark/util/kvstore/InMemoryStoreSuite.java
##########
@@ -132,6 +133,48 @@ public void testArrayIndices() throws Exception {
assertEquals(o,
store.view(ArrayKeyIndexType.class).index("id").first(o.id).iterator().next());
}
+ @Test
+ public void testRemoveAll() throws Exception {
+ KVStore store = new InMemoryStore();
+
+ for (int i = 0; i < 2; i++) {
+ for (int j = 0; j < 2; j++) {
+ ArrayKeyIndexType o = new ArrayKeyIndexType();
+ o.key = new int[] { i, j, 0 };
+ o.id = new String[] { "things" };
+ store.write(o);
+
+ o = new ArrayKeyIndexType();
+ o.key = new int[] { i, j, 1 };
+ o.id = new String[] { "more things" };
+ store.write(o);
+ }
+ }
+
+ ArrayKeyIndexType o = new ArrayKeyIndexType();
+ o.key = new int[] { 2, 2, 2 };
+ o.id = new String[] { "things" };
+ store.write(o);
+
+ assertEquals(9, store.count(ArrayKeyIndexType.class));
+
+ HashSet set = new HashSet();
Review comment:
Add generic type.
Or you could use `ImmutableSet` and not need this local variable (and avoid
re-using it for different types and avoid the warnings from javac at the same
time).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
