dongjoon-hyun commented on a change in pull request #24221: [SPARK-27248][SQL]
`refreshTable` should recreate cache with same cache name and storage level
URL: https://github.com/apache/spark/pull/24221#discussion_r285421984
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/test/SQLTestUtils.scala
##########
@@ -299,6 +299,27 @@ private[sql] trait SQLTestUtilsBase
}
}
+ /**
+ * Drops cache `cacheName` after calling `f`.
+ */
+ protected def withCache(cacheNames: String*)(f: => Unit): Unit = {
+ try f finally {
+ cacheNames.foreach(uncacheTable)
+ }
+ }
Review comment:
Could you update like the following? Like the other `withXXX` functions,
`withCache` should clean up multiple cache names in the `finally` clause.
```scala
protected def withCache(cacheNames: String*)(f: => Unit): Unit = {
try f finally {
- cacheNames.foreach(uncacheTable)
+ cacheNames.foreach { cacheName =>
+ try uncacheTable(cacheName) catch {
+ case _: AnalysisException =>
+ }
+ }
}
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
