dongjoon-hyun commented on a change in pull request #24221: [SPARK-27248][SQL]
`refreshTable` should recreate cache with same cache name and storage level
URL: https://github.com/apache/spark/pull/24221#discussion_r285422109
##########
File path:
sql/hive/src/test/scala/org/apache/spark/sql/hive/CachedTableSuite.scala
##########
@@ -49,16 +49,7 @@ class CachedTableSuite extends QueryTest with SQLTestUtils
with TestHiveSingleto
maybeBlock.nonEmpty
}
- // Blocking uncache table for tests
- private def uncacheTable(tableName: String): Unit = {
- val tableIdent =
spark.sessionState.sqlParser.parseTableIdentifier(tableName)
- val cascade = !spark.sessionState.catalog.isTemporaryTable(tableIdent)
- spark.sharedState.cacheManager.uncacheQuery(
- spark,
- spark.table(tableName).logicalPlan,
- cascade = cascade,
- blocking = true)
- }
+
Review comment:
Remove the blank line 52. Removing the existing one is enough and we don't
need to add another blank line here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
