GitHub user viirya opened a pull request:
https://github.com/apache/spark/pull/3899
[Minor][Mllib] Simplify loss function
This is a minor pr where I think that we can simply take minus of `margin`
here, instead of subtracting `margin`.
Mathematically, they are equal. But the modified equation is the common
form of logistic loss function and so more readable. It also computes more
accurate value as some quick tests show.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/viirya/spark-1 logit_func
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/3899.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3899
----
commit 2bc5712a6fe374c0821233edab719b58d31ab01b
Author: Liang-Chi Hsieh <[email protected]>
Date: 2015-01-05T09:13:07Z
Simplify loss function.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
