Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/3899#issuecomment-68749063
@viirya Thanks for the improvement! We could make this computation more
accurate. We should branch based on `sign(label) * margin`, similar to
https://github.com/apache/spark/blob/master/mllib/src/main/scala/org/apache/spark/mllib/tree/loss/LogLoss.scala#L64
Do you have time making this change? Or I can merge this PR and create a
JIRA as a reminder.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
