Github user pwendell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2982#discussion_r22502975
  
    --- Diff: bin/compute-classpath.cmd ---
    @@ -109,6 +115,24 @@ if "x%YARN_CONF_DIR%"=="x" goto no_yarn_conf_dir
       set CLASSPATH=%CLASSPATH%;%YARN_CONF_DIR%
     :no_yarn_conf_dir
     
    +rem Add hadoop conf dir - else FileSystem.*, etc fail
    +rem Note, this assumes that there is either a HADOOP_CONF_DIR or 
YARN_CONF_DIR which hosts
    +rem the configurtion files.
    +if "x%HADOOP_CONF_DIR%"=="x" goto no_hadoop_conf_dir
    --- End diff --
    
    Is there a reason these blocks are written using `goto`'s unlike the other 
`if` statements in this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to