Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/2982#issuecomment-68817799
Hey @vanzin - I took a look through this. Many of the changes seem like a
good idea and a nice restructuring of the build. Thanks for keeping this up to
date for so long.
I was a bit concerned about the two new environment variables that were
added to the classpath scripts, because it seemed like these needs could be
satisfied without introducing additional configs. I.e. we just set the existing
options to spark-submit (for the tests) or in a configuration file (for
distributors). Having more ways in which the classpath can be set makes it hard
to debug things. For the test code, the logic for writing and reading
SPARK_TEST_PARENT_CLASS_PATH are in totally different locations, making it
slightly clunkier than if the classpath were just augmented at the site where
the Command is generated.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
