dbtsai commented on a change in pull request #24682: [SPARK-27762][SQL] [FOLLOWUP] Add behavior change for Avro writer in migration guide URL: https://github.com/apache/spark/pull/24682#discussion_r286731575
########## File path: external/avro/src/main/scala/org/apache/spark/sql/avro/AvroSerializer.scala ########## @@ -234,7 +234,7 @@ class AvroSerializer(rootCatalystType: DataType, rootAvroType: Schema, nullable: } private def resolveNullableType(avroType: Schema, nullable: Boolean): Schema = { - if (nullable && avroType.getType != NULL) { + if (avroType.getType == Type.UNION && nullable) { // avro uses union to represent nullable type. val fields = avroType.getTypes.asScala Review comment: This is a bug, and only when `avroType.getType == Type.UNION` should go through this code path. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org