dbtsai commented on a change in pull request #24682: [SPARK-27762][SQL]
[FOLLOWUP] Add behavior change for Avro writer in migration guide
URL: https://github.com/apache/spark/pull/24682#discussion_r286797484
##########
File path:
external/avro/src/test/scala/org/apache/spark/sql/avro/AvroSuite.scala
##########
@@ -930,6 +930,33 @@ class AvroSuite extends QueryTest with SharedSQLContext
with SQLTestUtils {
}
}
+ test("support user provided non-nullable avro schema " +
+ "for nullable catalyst schema without any null record") {
Review comment:
Adding warning message is good idea for me.
If we want to forbid this, we need to load the Avro with correct schema from
the beginning. Currently, all the avro files will be loaded as `nullable ==
true` in catalyst schema even it's not nullable in the original avro schema.
The round-trip of the loading and writing can result different schemas. This is
the only workaround to write a non-nullable schema in avro easily to maintain
the same schema.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
