maryannxue commented on a change in pull request #24653: [SPARK-27783][SQL] Add
customizable hint error handler
URL: https://github.com/apache/spark/pull/24653#discussion_r287050621
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/EliminateResolvedHint.scala
##########
@@ -37,7 +41,7 @@ object EliminateResolvedHint extends Rule[LogicalPlan] {
}
pulledUp.transformUp {
case h: ResolvedHint =>
- handleInvalidHintInfo(h.hints)
+ hintErrorHandler.handleJoinNotFoundForJoinHint(h.hints)
Review comment:
No. The original name is not accurate. This rule basically extract hints
nodes from child relations of a join and pull them up to the Join node. If we
come up with other "invalid hints" later, we can have other error handler
callbacks specific to those invalid hints.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
