maryannxue commented on a change in pull request #24653: [SPARK-27783][SQL] Add
customizable hint error handler
URL: https://github.com/apache/spark/pull/24653#discussion_r287522772
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/EliminateResolvedHint.scala
##########
@@ -37,7 +41,7 @@ object EliminateResolvedHint extends Rule[LogicalPlan] {
}
pulledUp.transformUp {
case h: ResolvedHint =>
- handleInvalidHintInfo(h.hints)
+ hintErrorHandler.handleJoinNotFoundForJoinHint(h.hints)
Review comment:
The hope is we'll be able to recognize the specific hint error in this rule
if anything else. Say if a XYZ-hint has to be associated with XYZ-node, we
should another error assigned to it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
