tgravescs commented on a change in pull request #24374: [SPARK-27366][CORE]
Support GPU Resources in Spark job scheduling
URL: https://github.com/apache/spark/pull/24374#discussion_r287139549
##########
File path: core/src/main/scala/org/apache/spark/SparkConf.scala
##########
@@ -500,6 +500,15 @@ class SparkConf(loadDefaults: Boolean) extends Cloneable
with Logging with Seria
}
}
+ /**
Review comment:
we lost the check to make sure the executor resources are a multiple of task
requirements, do you want to add that back?
note I added a check
(https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/SparkConf.scala#L609)
to make sure they were large enough but not that it was an exact fit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
