tgravescs commented on a change in pull request #24374: [SPARK-27366][CORE]
Support GPU Resources in Spark job scheduling
URL: https://github.com/apache/spark/pull/24374#discussion_r287383789
##########
File path: core/src/main/scala/org/apache/spark/internal/config/package.scala
##########
@@ -179,6 +179,7 @@ package object config {
private[spark] val EXECUTOR_CORES =
ConfigBuilder(SparkLauncher.EXECUTOR_CORES)
.intConf
+ .checkValue(_ > 0, "Each executor must contain at least 1 cpu core.")
Review comment:
this is probably not needed here as we already check it in
SparkSubmitArguments:
Exception in thread "main" org.apache.spark.SparkException: Executor cores
must be a positive number
at
org.apache.spark.deploy.SparkSubmitArguments.error(SparkSubmitArguments.scala:658)
at
org.apache.spark.deploy.SparkSubmitArguments.validateSubmitArguments(SparkSubmitArguments.scala:284)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
