tgravescs commented on a change in pull request #24703: [SPARK-27362][K8S]
Resource Scheduling support for k8s
URL: https://github.com/apache/spark/pull/24703#discussion_r288704248
##########
File path:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/BasicDriverFeatureStep.scala
##########
@@ -129,6 +132,7 @@ private[spark] class BasicDriverFeatureStep(conf:
KubernetesDriverConf)
.addToLimits(maybeCpuLimitQuantity.toMap.asJava)
.addToRequests("memory", driverMemoryQuantity)
.addToLimits("memory", driverMemoryQuantity)
+ .addToLimits(driverResourceQuantities.toMap.asJava)
Review comment:
I'm going by https://kubernetes.io/docs/tasks/manage-gpus/scheduling-gpus/
-> GPUs are only supposed to be specified in the limits
also assuming that all resource plugins use limits going by:
https://kubernetes.io/docs/concepts/extend-kubernetes/compute-storage-net/device-plugins/
where it just has:
containers:
- name: demo-container-1
image: k8s.gcr.io/pause:2.0
resources:
limits:
vendor-domain/resource: 2 # requesting 2 vendor-domain/resource
If there is other documentation that says otherwise please let me know
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
