tgravescs commented on a change in pull request #24703: [SPARK-27362][K8S]
Resource Scheduling support for k8s
URL: https://github.com/apache/spark/pull/24703#discussion_r288704815
##########
File path:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/KubernetesConf.scala
##########
@@ -199,4 +199,13 @@ private[spark] object KubernetesConf {
.replaceAll("[^a-z0-9\\-]", "")
.replaceAll("-+", "-")
}
+
+ /**
+ * Build a resources name based on the vendor device plugin naming
+ * convention of: vendor-domain/resource. For example, an Nvidia GPU is
+ * advertised as nvidia.com/gpu.
+ */
+ def buildKubernetesResourceName(vendor: String, resourceName: String):
String = {
+ s"${vendor}/${resourceName}"
Review comment:
that is what k8s takes from reading the docs, if I am wrong please point me
to correct docs
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
