peter-toth commented on a change in pull request #24742: [SPARK-27881][SQL]
Support CAST (... FORMAT <pattern>) expression
URL: https://github.com/apache/spark/pull/24742#discussion_r289281432
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
##########
@@ -1272,7 +1272,8 @@ class AstBuilder(conf: SQLConf) extends
SqlBaseBaseVisitor[AnyRef] with Logging
* Create a [[Cast]] expression.
*/
override def visitCast(ctx: CastContext): Expression = withOrigin(ctx) {
- Cast(expression(ctx.expression), visitSparkDataType(ctx.dataType))
+ Cast(expression(ctx.expression()), visitSparkDataType(ctx.dataType),
Review comment:
As far as I know case class (the new expression `FormattedCast`) can't
inherit from another case class (`Cast`). We could create a `CastBase` trait or
abstract class with the common logic and inherit inherit both `Cast` and
`FormattedCast` from it, but I still see the issue that many places we use
pattern matching with `Cast`. We can add matching to `FormattedCast` to these
places now, but I feel it will be a bit error prone for the future and some
might forget to match `FormattedCast` too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
