peter-toth commented on a change in pull request #24742: [SPARK-27881][SQL]
Support CAST (... FORMAT <pattern>) expression
URL: https://github.com/apache/spark/pull/24742#discussion_r289422604
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
##########
@@ -862,11 +933,45 @@ case class Cast(child: Expression, dataType: DataType,
timeZoneId: Option[String
from match {
case BinaryType =>
(c, evPrim, evNull) => code"$evPrim = UTF8String.fromBytes($c);"
+ case DateType if format.isDefined =>
+ (c, evPrim, evNull) =>
+ if (customDateFormatter == null) {
+ code"""$evNull = true;"""
+ } else {
+ val formatterClass = classOf[DateFormatter]
+ val fmtr = JavaCode.global(
+ ctx.addReferenceObj("formatter", customDateFormatter,
formatterClass.getName),
+ formatterClass)
+ code"""
+ |try {
+ | $evPrim = UTF8String.fromString($fmtr.format($c));
+ |} catch (java.lang.IllegalArgumentException e) {
Review comment:
I don't think that `DateFormatter.format()` can throw `ArithmeticException`
but `TimestampFormatter` can, so added there. `DateTimeException` catch is
added to both places.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
