rdblue commented on a change in pull request #24723: [SPARK-27857][SQL] Move
ALTER TABLE parsing into Catalyst
URL: https://github.com/apache/spark/pull/24723#discussion_r289489677
##########
File path:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4
##########
@@ -113,14 +113,29 @@ statement
LIKE source=tableIdentifier locationSpec?
#createTableLike
| ANALYZE TABLE tableIdentifier partitionSpec? COMPUTE STATISTICS
(identifier | FOR COLUMNS identifierSeq | FOR ALL COLUMNS)? #analyze
- | ALTER TABLE tableIdentifier
- ADD COLUMNS '(' columns=colTypeList ')'
#addTableColumns
+ | ALTER TABLE multipartIdentifier
+ ADD (COLUMN | COLUMNS) columns=newColumnList colPosition?
#addTableColumns
+ | ALTER TABLE multipartIdentifier
+ ADD (COLUMN | COLUMNS)
+ '(' columns=newColumnList ')' colPosition?
#addTableColumns
+ | ALTER TABLE multipartIdentifier
+ RENAME COLUMN from=qualifiedName TO to=identifier
#renameTableColumn
+ | ALTER TABLE multipartIdentifier
+ DROP (COLUMN | COLUMNS) '(' columns=qualifiedNameList ')'
#dropTableColumns
+ | ALTER TABLE multipartIdentifier
+ DROP (COLUMN | COLUMNS) columns=qualifiedNameList
#dropTableColumns
| ALTER (TABLE | VIEW) from=tableIdentifier
RENAME TO to=tableIdentifier
#renameTable
- | ALTER (TABLE | VIEW) tableIdentifier
+ | ALTER (TABLE | VIEW) multipartIdentifier
SET TBLPROPERTIES tablePropertyList
#setTableProperties
- | ALTER (TABLE | VIEW) tableIdentifier
+ | ALTER (TABLE | VIEW) multipartIdentifier
UNSET TBLPROPERTIES (IF EXISTS)? tablePropertyList
#unsetTableProperties
+ | ALTER TABLE multipartIdentifier
+ (ALTER | CHANGE) COLUMN? qualifiedName
+ TYPE dataType (COMMENT comment=STRING)? colPosition?
#alterTableColumn
+ | ALTER TABLE multipartIdentifier
+ (ALTER | CHANGE) COLUMN? qualifiedName
+ COMMENT comment=STRING colPosition?
#alterTableColumn
Review comment:
Will do.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
