rdblue commented on a change in pull request #24723: [SPARK-27857][SQL] Move
ALTER TABLE parsing into Catalyst
URL: https://github.com/apache/spark/pull/24723#discussion_r290385763
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
##########
@@ -2213,4 +2220,150 @@ class AstBuilder(conf: SQLConf) extends
SqlBaseBaseVisitor[AnyRef] with Logging
visitMultipartIdentifier(ctx.multipartIdentifier()),
ctx.EXISTS != null)
}
+
+ /**
+ * Parse new column info from ADD COLUMN into a QualifiedColType.
+ */
+ override def visitQualifiedColTypeWithPosition(
+ ctx: QualifiedColTypeWithPositionContext): QualifiedColType =
withOrigin(ctx) {
+ if (ctx.colPosition != null) {
+ operationNotAllowed("ALTER TABLE table ADD COLUMN ... FIRST | AFTER
otherCol", ctx)
+ }
+
+ QualifiedColType(
+ typedVisit[Seq[String]](ctx.name),
+ typedVisit[DataType](ctx.dataType),
+ Option(ctx.comment).map(string))
+ }
+
+ /**
+ * Parse a [[AlterTableAddColumnsStatement]] command.
+ *
+ * For example:
+ * {{{
+ * ALTER TABLE table1
+ * ADD COLUMNS (col_name data_type [COMMENT col_comment], ...);
+ * }}}
+ */
+ override def visitAddTableColumns(ctx: AddTableColumnsContext): LogicalPlan
= withOrigin(ctx) {
+ AlterTableAddColumnsStatement(
+ visitMultipartIdentifier(ctx.multipartIdentifier),
+
ctx.columns.qualifiedColTypeWithPosition.asScala.map(typedVisit[QualifiedColType])
+ )
+ }
+
+ /**
+ * Parse a [[AlterTableRenameColumnStatement]] command.
+ *
+ * For example:
+ * {{{
+ * ALTER TABLE table1 RENAME COLUMN a.b.c TO x
+ * }}}
+ */
+ override def visitRenameTableColumn(
+ ctx: RenameTableColumnContext): LogicalPlan = withOrigin(ctx) {
+ AlterTableRenameColumnStatement(
+ visitMultipartIdentifier(ctx.multipartIdentifier),
+ ctx.from.identifier.asScala.map(_.getText),
+ ctx.to.getText)
+ }
+
+ /**
+ * Parse a [[AlterTableAlterColumnStatement]] command.
+ *
+ * For example:
+ * {{{
+ * ALTER TABLE table1 ALTER COLUMN a.b.c TYPE bigint
+ * ALTER TABLE table1 ALTER COLUMN a.b.c TYPE bigint COMMENT 'new comment'
+ * ALTER TABLE table1 ALTER COLUMN a.b.c COMMENT 'new comment'
+ * }}}
+ */
+ override def visitAlterTableColumn(
+ ctx: AlterTableColumnContext): LogicalPlan = withOrigin(ctx) {
+ if (ctx.colPosition != null) {
+ operationNotAllowed("ALTER TABLE table CHANGE COLUMN ... FIRST | AFTER
otherCol", ctx)
Review comment:
Both are supported, but CHANGE was supported first and is used in other
places. I used CHANGE For consistency.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
