rdblue commented on a change in pull request #24741: [SPARK-27322][SQL]
DataSourceV2: Select from multiple catalogs
URL: https://github.com/apache/spark/pull/24741#discussion_r289974736
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveHints.scala
##########
@@ -50,11 +51,15 @@ object ResolveHints {
*
* This rule must happen before common table expressions.
*/
- class ResolveJoinStrategyHints(conf: SQLConf) extends Rule[LogicalPlan] {
+ class ResolveJoinStrategyHints(
+ conf: SQLConf,
+ catalogLookup: String => CatalogPlugin) extends Rule[LogicalPlan] with
LookupCatalog {
Review comment:
I think it is cleaner to pass an existing `LookupCatalog` instance. In the
v2 session catalog PR, I updated `DataSourceResolution` to use a lookup that is
passed in instead:
https://github.com/apache/spark/pull/24768/files#diff-acba0f0ea96f6511882f4ead4fb33dc2R44
I think that would be a cleaner way to get the identifier extractors.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
