rdblue commented on a change in pull request #24723: [SPARK-27857][SQL] Move
ALTER TABLE parsing into Catalyst
URL: https://github.com/apache/spark/pull/24723#discussion_r290440344
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLParserSuite.scala
##########
@@ -758,40 +719,15 @@ class DDLParserSuite extends AnalysisTest with
SharedSQLContext {
"SET FILEFORMAT PARQUET")
}
- test("alter table: set location") {
- val sql1 = "ALTER TABLE table_name SET LOCATION 'new location'"
+ test("alter table: set partition location") {
val sql2 = "ALTER TABLE table_name PARTITION (dt='2008-08-08',
country='us') " +
"SET LOCATION 'new location'"
- val parsed1 = parser.parsePlan(sql1)
val parsed2 = parser.parsePlan(sql2)
val tableIdent = TableIdentifier("table_name", None)
- val expected1 = AlterTableSetLocationCommand(
- tableIdent,
- None,
- "new location")
val expected2 = AlterTableSetLocationCommand(
tableIdent,
Some(Map("dt" -> "2008-08-08", "country" -> "us")),
"new location")
- comparePlans(parsed1, expected1)
- comparePlans(parsed2, expected2)
- }
-
- test("alter table: change column name/type/comment") {
Review comment:
The parser didn't change for this variant of `CHANGE COLUMN`, so I'm adding
it back. Looks like I just removed it accidentally.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
