gatorsmile commented on a change in pull request #24741: [SPARK-27322][SQL]
DataSourceV2: Select from multiple catalogs
URL: https://github.com/apache/spark/pull/24741#discussion_r290524760
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/views.scala
##########
@@ -181,6 +182,11 @@ case class CreateViewCommand(
* Permanent views are not allowed to reference temp objects, including temp
function and views
*/
private def verifyTemporaryObjectsNotExists(sparkSession: SparkSession):
Unit = {
+ val lookup = new LookupCatalog {
+ override protected def lookupCatalog(name: String): CatalogPlugin =
sparkSession.catalog(name)
+ }
+ import lookup._
Review comment:
Do we need to build a new `LookupCatalog`?
How about directly using the analyzer's AsTableIdentifier?
> sparkSession.sessionState.analyzer.AsTableIdentifier(ident))
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
