gatorsmile commented on a change in pull request #24741: [SPARK-27322][SQL]
DataSourceV2: Select from multiple catalogs
URL: https://github.com/apache/spark/pull/24741#discussion_r290524858
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/views.scala
##########
@@ -190,10 +196,11 @@ case class CreateViewCommand(
// package (e.g., HiveGenericUDF).
child.collect {
// Disallow creating permanent views based on temporary views.
- case s: UnresolvedRelation
- if
sparkSession.sessionState.catalog.isTemporaryTable(s.tableIdentifier) =>
+ case UnresolvedRelation(AsTableIdentifier(ident))
+ if sparkSession.sessionState.catalog.isTemporaryTable(ident) =>
+ // temporary views are only stored in the session catalog
throw new AnalysisException(s"Not allowed to create a permanent view
$name by " +
- s"referencing a temporary view ${s.tableIdentifier}")
+ s"referencing a temporary view $ident")
Review comment:
Nit: indent.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
