gatorsmile commented on a change in pull request #24774: [SPARK-27899][SQL]
Make HiveMetastoreClient.getTableObjectsByName available in
ExternalCatalog/SessionCatalog API
URL: https://github.com/apache/spark/pull/24774#discussion_r290541536
##########
File path:
sql/hive/src/test/scala/org/apache/spark/sql/hive/client/VersionsSuite.scala
##########
@@ -237,6 +237,10 @@ class VersionsSuite extends SparkFunSuite with Logging {
assert(client.getTableOption("default", "src").isDefined)
}
+ test(s"$version: getTablesByName") {
+ assert(client.getTablesByName("default", Seq("src")).nonEmpty)
Review comment:
this only covers a single table. How about multiple tables? or mixed with
non-existent tables? with illegal table names? or an empty seq? and so on. :-)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
